chore(deps-dev): bump karma-jasmine from 1.1.2 to 5.1.0 in /build#40153
chore(deps-dev): bump karma-jasmine from 1.1.2 to 5.1.0 in /build#40153dependabot[bot] wants to merge 2 commits into
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Code Review — Bump karma-jasmine from 1.1.2 to 5.1.0 in /build
Automated Dependabot dependency bump for karma-jasmine (test adapter). Major version bump (1.x → 5.x). Test infrastructure change only — no production code affected.
Run make test-js to verify all existing JS tests still pass with karma-jasmine 5.1.0.
Verdict: Needs test validation. Run make test-js to confirm compatibility, then ready to merge.
|
@dependabot rebase |
Bumps [karma-jasmine](https://github.com/karma-runner/karma-jasmine) from 1.1.2 to 5.1.0. - [Release notes](https://github.com/karma-runner/karma-jasmine/releases) - [Changelog](https://github.com/karma-runner/karma-jasmine/blob/master/CHANGELOG.md) - [Commits](karma-runner/karma-jasmine@v1.1.2...v5.1.0) --- updated-dependencies: - dependency-name: karma-jasmine dependency-version: 5.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/build/karma-jasmine-5.1.0
branch
from
0c98af5 to
2232d8d
Compare
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Code Review — chore(deps-dev): bump karma-jasmine from 1.1.2 to 5.1.0 in /build
Updated from previous review — this rebased PR now also pulls in jasmine-core@^4.1.0 as a transitive dependency of karma-jasmine 5.x (resolved to 4.6.1 in the lockfile, in addition to the existing 2.99.1 entry which is kept for other consumers).
Test infra only — no production code affected. Run make test-js to verify all existing JS tests pass with the new karma-jasmine/jasmine-core versions before merging.
Verdict: Needs test validation. Run make test-js to confirm compatibility, then ready to merge.
Mirror the Drone CI javascript() pipeline in GitHub Actions by adding a local reusable workflow (js-unit.yml) that runs `make test-js` via Karma, and wiring it into ci.yml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
This PR has been updated since the last review. The new commits add a dedicated js-unit.yml reusable workflow and wire it into ci.yml as the js-unit job — this is a meaningful structural addition on top of the original karma-jasmine version bump.
On the new CI workflow (js-unit.yml):
- Node.js 18 is pinned via
setup-node@v4but without a digest pin, while thecheckoutstep uses a pinned digest (df4cb1c...). For consistency (and supply-chain hygiene) consider pinningsetup-nodeto a digest as well. - The workflow installs Firefox via
sudo apt-get install -y firefoxwithout-qor--no-install-recommends, which is minor but slightly slower than it needs to be. make test-jsas the test entry point is clean and idiomatic.
On the original bump (karma-jasmine 1.1.2 → 5.1.0):
- This is a large major-version jump (1 → 5). The v5.0.0 breaking changes include: minimum karma
^6.0.0, minimum Node 12, and jasmine-core bumped to 4.x. Confirmpackage.jsonalready has"karma": "^6.4.4"(it does — visible in the diff) and that existing tests pass under the new jasmine-core 4.x API. - The PR has been open >30 days and auto-rebase is disabled — worth rebasing to confirm there are no conflicts with recent changes to
build/.
The new CI job is a good addition that ensures JS tests are gated in CI. Once the tests pass cleanly, this is ready to merge.
2 participants
Bumps karma-jasmine from 1.1.2 to 5.1.0.
Release notes
Sourced from karma-jasmine's releases.
... (truncated)
Changelog
Sourced from karma-jasmine's changelog.
... (truncated)
Commits
c3f702achore(release): 5.1.0 [skip ci]b73dbd6feat(spec-filter): allow custom specFilter58d5d25chore(release): 5.0.1 [skip ci]e964fa6fix: fixes matches performance issue, github#302819d42ddocs: make grep behaviour clearer963269dbuild: add missing husky package, sort out the eslint packages4437021docs: minor README.md tweaksb7b7e6bchore(release): 5.0.0 [skip ci]d72c124fix: limit karma peer dependency to ^6.0.0ea691e8build: drop Node.js 10 support